[PATCH] D64091: ScheduleDAG: Fix incorrectly killing registers in bundles

Fri Jul 5 03:55:33 PDT 2019

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wuzish.

LGTM, thanks!

================
Comment at: lib/CodeGen/ScheduleDAGInstrs.cpp:1107
     } else {
       MachineBasicBlock::instr_iterator First = MI.getIterator();
       if (MI.isBundle()) {
----------------
I think this is not well named. It does not point to the first instruction in the bundle, but the BUNDLE. IMO it would be good to adjust that.

================
Comment at: lib/CodeGen/ScheduleDAGInstrs.cpp:1108
       MachineBasicBlock::instr_iterator First = MI.getIterator();
       if (MI.isBundle()) {
         toggleKills(MRI, LiveRegs, MI, false);
----------------
nit: no braces required anymore.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64091/new/

https://reviews.llvm.org/D64091