[PATCH] D64206: [llvm\test\Object] - An initial step to cleanup the test cases.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 5 03:01:24 PDT 2019
MaskRay added inline comments.
================
Comment at: test/Object/readobj.test:2
-// Don't crash while reading non-dynamic files.
-RUN: llvm-readobj %p/Inputs/trivial-object-test.elf-x86-64
----------------
jhenderson wrote:
> Perhaps this needs to be a "does nothing if no operations requested" test, if it doesn't exist already?
`test/tools/llvm-readobj/elf-dynamic-*` test various .dynamic features. This file can be moved there if you feel strong about keeping it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64206/new/
https://reviews.llvm.org/D64206
More information about the llvm-commits
mailing list