[PATCH] D64206: [llvm\test\Object] - An initial step to cleanup the test cases.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 5 01:58:10 PDT 2019


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: test/Object/X86/objdump-disassembly-inline-relocations.test:106
+    Address: 0x0000000000000034
+    Link:    .symtab
+    Info:    .text
----------------
jhenderson wrote:
> MaskRay wrote:
> > jhenderson wrote:
> > > This line can be deleted.
> > I think James meant the `Address: 0x0000000000000034` line.
> Nope, I meant the Link line. I believe that yaml2obj automatically links the section to .symtab unless told otherwise.
Both of these lines can be removed :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64206/new/

https://reviews.llvm.org/D64206





More information about the llvm-commits mailing list