[PATCH] D64236: [llvm-objcopy] Don't change permissions of non-regular output files

[Alex Brachet via Phabricator via llvm-commits]

abrachet added a comment.

Thanks @MaskRay, this is a big upgrade to what I had.



================
Comment at: lib/Support/Windows/Path.inc:773
+std::error_code setPermissions(int FD, perms Permissions) {
+  // FIXME Not implemented.
+  return std::error_code();
----------------
By no means a Windows expert, but it seems like [[ https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/get-osfhandle?view=vs-2019 | _get_osfhandle ]] and [[ https://docs.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-setfileinformationbyhandle | SetFileInformationByHandle ]] would be a place to start?


================
Comment at: unittests/Support/Path.cpp:1541
 
 TEST_F(FileSystemTest, RespectUmask) {
 #ifndef _WIN32
----------------
I'm not sure this test fixture is needed anymore, but it's also not hurting.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64236/new/

https://reviews.llvm.org/D64236