[PATCH] D64236: [llvm-objcopy] Don't change permissions of non-regular output files

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 4 23:53:01 PDT 2019


MaskRay updated this revision to Diff 208122.
MaskRay added a comment.

Add a #ifdef _Win32 to (hopefully) fix Windows tests.
I don't know how to implement fchmod on Windows...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64236/new/

https://reviews.llvm.org/D64236

Files:
  include/llvm/Support/FileSystem.h
  lib/Support/Unix/Path.inc
  lib/Support/Windows/Path.inc
  test/tools/llvm-objcopy/ELF/mirror-permissions-unix.test
  tools/llvm-objcopy/llvm-objcopy.cpp
  unittests/Support/Path.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64236.208122.patch
Type: text/x-patch
Size: 6356 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190705/c0886060/attachment.bin>


More information about the llvm-commits mailing list