[PATCH] D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked 22 inline comments as done.
sfertile added inline comments.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:162
+
+  // Constuctor and create function. Constructor builds only a base class
+  // object, while the 'create' function fills-out the XCOFF specific info
----------------
hubert.reinterpretcast wrote:
> Typo: "Constuctor [//sic//]".
> 
> Suggestion:
> Constructor and "create" factory function. The constructor is only a thin wrapper around the base constructor. The "create" function fills out the XCOFF-specific information and performs the error checking along the way.
Updated with suggested comment.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:386
+  default:
+    Expected<DataRefImpl> SI = getSectionByNum(SectionNum);
+    if (SI)
----------------
hubert.reinterpretcast wrote:
> What does `SI` mean?
No idea :S. Updated to a more appropriate name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63843/new/

https://reviews.llvm.org/D63843