[PATCH] D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping.

[Sean Fertile via Phabricator via llvm-commits]

sfertile updated this revision to Diff 208078.
sfertile added a comment.
Herald added a subscriber: wuzish.

- Lots of tweaks to comments and whitespace.
  - Added assertion to 'getPointerToSymbolTable`
  - Changed name of local variable in `getSymbolSectionName` to be more descriptive.
  - Use `checkOffset` and `getObject'`in `parseStringTable`.
  - Changed unreachables to report_fatal_error in 'printSectionHeaders`.
  - Added TODO where overflow checking eventually needs to be done.
  - Added comment about DWARF subsection types, & limited section flag printing to the section type flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63843/new/

https://reviews.llvm.org/D63843

Files:
  llvm/include/llvm/BinaryFormat/Magic.h
  llvm/include/llvm/Object/Binary.h
  llvm/include/llvm/Object/ObjectFile.h
  llvm/include/llvm/Object/XCOFFObjectFile.h
  llvm/lib/BinaryFormat/Magic.cpp
  llvm/lib/Object/Binary.cpp
  llvm/lib/Object/ObjectFile.cpp
  llvm/lib/Object/SymbolicFile.cpp
  llvm/lib/Object/XCOFFObjectFile.cpp
  llvm/test/tools/llvm-readobj/Inputs/xcoff-basic-64.o
  llvm/test/tools/llvm-readobj/xcoff-basic.test
  llvm/test/tools/llvm-readobj/xcoff-sections.test
  llvm/tools/llvm-readobj/XCOFFDumper.cpp
  llvm/tools/obj2yaml/xcoff2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63843.208078.patch
Type: text/x-patch
Size: 44701 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190704/5f3137f9/attachment.bin>