[PATCH] D64141: [CodeGen] Add larger vector types for i32 and f32

[David Majnemer via Phabricator via llvm-commits]

majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM

In D64141#1568924 <https://reviews.llvm.org/D64141#1568924>, @ThomasR wrote:

> In D64141#1568896 <https://reviews.llvm.org/D64141#1568896>, @jmolloy wrote:
>
> > Most of this looks mechanical; I don't think the MVT changes should be contentious. However, the "is65536BitVector()" predicates are starting to get a bit unwieldy to read.
> >
> > Does an out of tree target need these predicates? I feel they're sufficiently unreadable to either change the format ("is64kBitVector"?) or elide them for larger types.
> >
> > Cheers,
> >
> > James
>
>
> I agree, it is not really needed I added it for consistency. I don't mind changing it to the format suggested. Which ones do you think should be changed?


It doesn't look like `is2048BitVector()` is used, maybe we just don't add any new predicates until a use-case comes up?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64141/new/

https://reviews.llvm.org/D64141