[PATCH] D64141: [CodeGen] Add larger vector types for i32 and f32

Thomas Raoux via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 11:39:10 PDT 2019


ThomasR marked an inline comment as done.
ThomasR added a comment.

In D64141#1568896 <https://reviews.llvm.org/D64141#1568896>, @jmolloy wrote:

> Most of this looks mechanical; I don't think the MVT changes should be contentious. However, the "is65536BitVector()" predicates are starting to get a bit unwieldy to read.
>
> Does an out of tree target need these predicates? I feel they're sufficiently unreadable to either change the format ("is64kBitVector"?) or elide them for larger types.
>
> Cheers,
>
> James


I agree, it is not really needed I added it for consistency. I don't mind changing it to the format suggested. Which ones do you think should be changed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64141/new/

https://reviews.llvm.org/D64141





More information about the llvm-commits mailing list