[PATCH] D64117: [WebAssembly][NFC] simplify SjLj inline assembly test

[Guanzhong Chen via Phabricator via llvm-commits]

quantum marked an inline comment as done.
quantum added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/lower-em-sjlj.ll:198
   %call = call i32 @setjmp(%struct.__jmp_buf_tag* %arraydecay) #4
-  %cmp = icmp eq i32 %call, 0
-  br i1 %cmp, label %if.then, label %if.else
-
-if.then:                                          ; preds = %entry
 ; CHECK: call void asm sideeffect "", ""()
   call void asm sideeffect "", ""()
----------------
aheejin wrote:
> aheejin wrote:
> > Oh one more thing. I think it's better to do
> > `CHECK-NOT: invoke void blah blah`
> > so that what this test is looking for. And maybe add a one-line comment that inline asms should NOT be transformed into invoke wrappers.
> so that what this test is looking for -> so that it is clear what this is looking for
If it generated an invoke wrapper, `opt` would exit with a failure. I'll put the `CHECK-NOT` in anyways to make it more explicit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64117/new/

https://reviews.llvm.org/D64117