[PATCH] D64117: [WebAssembly][NFC] simplify SjLj inline assembly test
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 2 18:36:12 PDT 2019
aheejin added inline comments.
================
Comment at: llvm/test/CodeGen/WebAssembly/lower-em-sjlj.ll:198
%call = call i32 @setjmp(%struct.__jmp_buf_tag* %arraydecay) #4
- %cmp = icmp eq i32 %call, 0
- br i1 %cmp, label %if.then, label %if.else
-
-if.then: ; preds = %entry
; CHECK: call void asm sideeffect "", ""()
call void asm sideeffect "", ""()
----------------
aheejin wrote:
> Oh one more thing. I think it's better to do
> `CHECK-NOT: invoke void blah blah`
> so that what this test is looking for. And maybe add a one-line comment that inline asms should NOT be transformed into invoke wrappers.
so that what this test is looking for -> so that it is clear what this is looking for
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64117/new/
https://reviews.llvm.org/D64117
More information about the llvm-commits
mailing list