[PATCH] D64125: [RISCV] Support @llvm.readcyclecounter() Intrinsic

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 09:55:15 PDT 2019


lenary updated this revision to Diff 207822.
lenary added a comment.

Address Review Feedback

- Updated lots of comments
- Added some asserts to trigger if we try to introduce or lower the custom pseudo-instruction on rv64.
- Clarify some magic numbers

Potentially this should wait for D64139 <https://reviews.llvm.org/D64139>, so we can use the named
constants that PR introduces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64125/new/

https://reviews.llvm.org/D64125

Files:
  llvm/lib/Target/RISCV/RISCVISelDAGToDAG.cpp
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/lib/Target/RISCV/RISCVISelLowering.h
  llvm/lib/Target/RISCV/RISCVInstrInfo.td
  llvm/test/CodeGen/RISCV/readcyclecounter.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64125.207822.patch
Type: text/x-patch
Size: 7804 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190703/c950df2b/attachment.bin>


More information about the llvm-commits mailing list