[PATCH] D63432: [ELF] Allow placing SHF_MERGE sections with different alignments into the same MergeSyntheticSection

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 08:41:26 PDT 2019


peter.smith added a comment.

I'm trying to think of possible problems that this change could have caused. I think that almost by definition of a merge section, you can't rely on the address of any entry to be unique. The one thing I can think of is something where the alignment requirements are higher than the entry size. By the definition of merge sections this doesn't make a lot of sense to me and might be considered a code-gen or user error.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63432/new/

https://reviews.llvm.org/D63432





More information about the llvm-commits mailing list