[PATCH] D63432: [ELF] Allow placing SHF_MERGE sections with different alignments into the same MergeSyntheticSection

Wed Jul 3 08:34:13 PDT 2019

MaskRay added a comment.

In D63432#1568457 <https://reviews.llvm.org/D63432#1568457>, @davezarzycki wrote:

> Well, as it turns out, `-DLLVM_LDFLAGS` is even less effective than the original CMAKE build options.
>
> I took your original suggestion and hacked LLVM's cmake to force `-Wl,-O0` instead of `-Wl,-O3`. A two stage build now works. Is this enough evidence to revert or fix this patch? Do you need any more tests?

Reverted in rL365048 <https://reviews.llvm.org/rL365048>.

I think some SHF_MERGE sections with the same name have different alignments. They were not merged before but were merged after r365015. Something that assumes address uniqueness of such mergeable data caused the failures. (The lld change still looks innocent to me but I guess it triggered some hidden issues)

I'll try reproducing the issue. If I fail to do that, I'll ask you for help to figure out the culprit :)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63432/new/

https://reviews.llvm.org/D63432