[PATCH] D63816: [ARM] WLS/LE Code Generation

[Sam Parker via Phabricator via llvm-commits]

samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp:12911
+  else
+    assert(Const->isOne() && "Expected to compare against 1");
+
----------------
RKSimon wrote:
> @samparker This is problematic on several levels... - we have an unused variable warning in NDEBUG builds and the else case only occurs if Const == NULL
> 
> ```
> if (isa<ConstantSDNode>(CC->getOperand(1)))
>   assert(cast<ConstantSDNode>(CC->getOperand(1)).isOne() && "Expected to compare against 1");
> ```
Ah - good point! I'll push up a fix. Thanks.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63816/new/

https://reviews.llvm.org/D63816