[PATCH] D63816: [ARM] WLS/LE Code Generation

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 3 05:58:04 PDT 2019


RKSimon added inline comments.


================
Comment at: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp:12911
+  else
+    assert(Const->isOne() && "Expected to compare against 1");
+
----------------
@samparker This is problematic on several levels... - we have an unused variable warning in NDEBUG builds and the else case only occurs if Const == NULL

```
if (isa<ConstantSDNode>(CC->getOperand(1)))
  assert(cast<ConstantSDNode>(CC->getOperand(1)).isOne() && "Expected to compare against 1");
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63816/new/

https://reviews.llvm.org/D63816





More information about the llvm-commits mailing list