[PATCH] D64081: AMDGPU: Look through bundles for existing waitcnts
Austin Kerbow via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 2 10:03:29 PDT 2019
kerbowa added a comment.
LGTM but I will wait for Stas.
================
Comment at: lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1360
- for (MachineBasicBlock::iterator Iter = Block.begin(), E = Block.end();
+ for (MachineBasicBlock::instr_iterator Iter = Block.instr_begin(),
+ E = Block.instr_end();
----------------
arsenm wrote:
> kerbowa wrote:
> > Can we just skip BUNDLE instructions.
> That's the opposite of the point. The point is to find the waitcnt inside the bundle
I mean the actual BUNDLE instruction itself, but it's not actually important.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64081/new/
https://reviews.llvm.org/D64081
More information about the llvm-commits
mailing list