[PATCH] D64081: AMDGPU: Look through bundles for existing waitcnts

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 2 09:55:31 PDT 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1360
 
-  for (MachineBasicBlock::iterator Iter = Block.begin(), E = Block.end();
+  for (MachineBasicBlock::instr_iterator Iter = Block.instr_begin(),
+                                         E = Block.instr_end();
----------------
kerbowa wrote:
> Can we just skip BUNDLE instructions.
That's the opposite of the point. The point is to find the waitcnt inside the bundle


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64081/new/

https://reviews.llvm.org/D64081





More information about the llvm-commits mailing list