[PATCH] D63785: Add support for MUSL libc

[Rich Felker via Phabricator via llvm-commits]

dalias added a comment.

I second the question, especially since I'm pretty sure that everything the existing asan code here is doing that makes it "work" on musl is poking at implementation internals that are not public interfaces and have no reason to continue "working" however they are now. A long time ago the question was raised of whether/how libcs could provide mechanisms for sanitizers to work, but the ideas I saw at the time were based on hooks, which we didn't consider reasonable from the musl side - as soon as hooks are offered as stable API, they WILL be used not just by sanitizers but by applications.

Also, I think most of the ifdefs above are conceptually wrong - they're hardcoding assumptions about musl and other libcs rather than detecting them. These should all be replaced by tests in the build system and `#ifdef HAVE_...` or similar.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63785/new/

https://reviews.llvm.org/D63785