[PATCH] D63785: Add support for MUSL libc

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 26 11:22:35 PDT 2019


kcc removed a reviewer: samsonov.
kcc added a comment.

Thanks for doing this!

This patch has too many #ifdefs, we can't accept it in this form. 
#ifdefs cost too much in maintenance.

My usual suggestions:

- turn #ifdefs into if () where possible
- move code to separate musl-specific files

However, may I have a different suggestion? 
The current libc-related sanitizer code is a huge mess because we don't have control over the LIBCs we have to support .
For the one libc we do have control over, our code is 100x simpler, and resides in that libc itself (our implementation of HWASAN for Android's bionic)
Will it be possible to have musl support the sanitizers instead of sanitizers support musl?


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63785/new/

https://reviews.llvm.org/D63785





More information about the llvm-commits mailing list