[PATCH] D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges

[Adrian Prantl via Phabricator via llvm-commits]

aprantl requested changes to this revision.
aprantl added a comment.
This revision now requires changes to proceed.

We need to come up with a better error handling strategy before this can be landed.



================
Comment at: lib/DebugInfo/GSYM/FileWriter.cpp:68
+  if (hasError())
+    return;
+  seek(SavedOffset);
----------------
I'm sure this can be improved. Currently this function checks for errors, but then silently discards them and returns void.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63828/new/

https://reviews.llvm.org/D63828