[PATCH] D63828: Add FileWriter to GSYM and encode/decode functions to AddressRange and AddressRanges

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added a comment.

This all LGTM now. Please wait long enough for others to get their say but overall I'm happy now.



================
Comment at: include/llvm/DebugInfo/GSYM/FileWriter.h:67
+  void operator=(const FileWriter &rhs) = delete;
+  bool hasError();
+};
----------------
Personal preference, can be this be a conversion to bool instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63828/new/

https://reviews.llvm.org/D63828