[PATCH] D60981: [TSan] Improve handling of stack pointer mangling in {set, long}jmp, pt.1

Fri Jun 28 10:27:14 PDT 2019

yln added a comment.

@dvyukov: I finally have a chance to continue working on this. I hope you are still onboard?
I plan to land this and let the bots (all the different architectures) churn on it over the weekend.

My next patch will be switching over the lookup to use the SP instead of the mangled SP, followed by some cleanup that is enabled by this.
I will make sure to put you as a reviewer for all of those.

In D60981#1475319 <https://reviews.llvm.org/D60981#1475319>, @dvyukov wrote:

> JmpBufGarbageCollect uses <= on sp values to detect bufs that are no longer active. But as far as I understand we still will able to do this, right?

Yes.

> It can make sense to combine the first part of LongJmp that extracts sp from context with UnmangleLongJmpSp in future changes, because they have effectively the same set of checks on OS/arch. E.g. GetSPFromContext that will both extract and demangle it.

I will do a round of cleanups and that sounds like a good candidate!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60981/new/

https://reviews.llvm.org/D60981