[PATCH] D63816: [ARM] WLS/LE Code Generation

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 09:11:07 PDT 2019


dmgreen added inline comments.


================
Comment at: lib/Target/ARM/ARMLowOverheadLoops.cpp:320
+    Start = ExpandLoopStart(ML, Start);
+    RemoveDeadBranch(Start);
+    End = ExpandLoopEnd(ML, Dec, End);
----------------
samparker wrote:
> dmgreen wrote:
> > These is something called ARMBaseInstrInfo::analyzeBranch which can help optimise away these unconditional fallthroughs too, if it can be made to work with loloop instructions.
> I'll add a TODO
Sounds good. Cheers. I'm not sure if those functions will be a little awkward to use with hardware loops, but they may allow some extra BB layout if we teach them how to analyse the branches.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63816/new/

https://reviews.llvm.org/D63816





More information about the llvm-commits mailing list