[PATCH] D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping.

[Sean Fertile via Phabricator via llvm-commits]

sfertile updated this revision to Diff 207069.
sfertile added a comment.

Address further comments:

- Simplified the address checking in 'checkSectionAddress'
- Removed unneeded asserts. As Digger pointed out, an symbol related function that casts a DataRefImpl.p to a symbol table entry already asserts in `toSymbolEntry`.

Still outstanding: cleaning up of the error handling in the constructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63843/new/

https://reviews.llvm.org/D63843

Files:
  llvm/include/llvm/BinaryFormat/Magic.h
  llvm/include/llvm/Object/Binary.h
  llvm/include/llvm/Object/ObjectFile.h
  llvm/include/llvm/Object/XCOFFObjectFile.h
  llvm/lib/BinaryFormat/Magic.cpp
  llvm/lib/Object/Binary.cpp
  llvm/lib/Object/ObjectFile.cpp
  llvm/lib/Object/SymbolicFile.cpp
  llvm/lib/Object/XCOFFObjectFile.cpp
  llvm/test/tools/llvm-readobj/Inputs/xcoff-basic-64.o
  llvm/test/tools/llvm-readobj/xcoff-basic.test
  llvm/test/tools/llvm-readobj/xcoff-sections.test
  llvm/tools/llvm-readobj/XCOFFDumper.cpp
  llvm/tools/obj2yaml/xcoff2yaml.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63843.207069.patch
Type: text/x-patch
Size: 39218 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190628/6bd10a2e/attachment.bin>