[PATCH] D63843: [Object][XCOFF] Add support for 64-bit file header and section header dumping.
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 28 07:12:13 PDT 2019
DiggerLin marked an inline comment as done.
DiggerLin added inline comments.
================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:501
// Get pointer to the symbol table.
- CurPtr = FileHdrPtr->SymbolTableOffset;
+ CurPtr = fileHeader32()->SymbolTableOffset;
uint64_t SymbolTableSize = (uint64_t)(sizeof(XCOFFSymbolEntry)) *
----------------
sfertile wrote:
> DiggerLin wrote:
> > if is64Bit(). it should return here.
> is64Bit() has already returned on line 495.
thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63843/new/
https://reviews.llvm.org/D63843
More information about the llvm-commits
mailing list