[PATCH] D63844: [LoopFusion] Extend use of OptimizationRemarkEmitter

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 07:25:03 PDT 2019


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopFusion/diagnostics_analysis.ll:3
+;
+; ModuleID = 'diagnostics_analysis.c'
+
----------------
Can this be dropped?


================
Comment at: llvm/test/Transforms/LoopFusion/diagnostics_analysis.ll:15
+  %i1 = alloca i32, align 4
+  store i32* %A, i32** %A.addr, align 8, !tbaa !27
+  store i32 %n, i32* %n.addr, align 4, !tbaa !32
----------------
is the tbaa metadata required for the test? I think the debug metadata could also be thinned out a bit. Same for the other test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63844/new/

https://reviews.llvm.org/D63844





More information about the llvm-commits mailing list