[PATCH] D63844: [LoopFusion] Extend use of OptimizationRemarkEmitter

[Ettore Tiotto via Phabricator via llvm-commits]

etiotto requested changes to this revision.
etiotto added a comment.
This revision now requires changes to proceed.

This looks pretty good to me. I just added some minor inline comments.



================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:82
 STATISTIC(InvalidDependencies, "Dependencies prevent fusion");
-STATISTIC(InvalidTripCount,
-          "Loop does not have invariant backedge taken count");
+STATISTIC(InvalidTripCount, "Loop has unknown trip count");
 STATISTIC(UncomputableTripCount, "SCEV cannot compute trip count of loop");
----------------
Nit:  InvalidTripCount --> UnknownTripCount


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:1145
+
+  void reportLoopFusion(const FusionCandidate &FC0,
+                        const FusionCandidate &FC1) {
----------------
Can you please add a comment similar to the comment for 'reportNoFusion'.  Also what do you think about adding a statistic to count the number of successful fusion opportunities?


================
Comment at: llvm/lib/Transforms/Scalar/LoopFuse.cpp:1146
+  void reportLoopFusion(const FusionCandidate &FC0,
+                        const FusionCandidate &FC1) {
+    using namespace ore;
----------------
assert FC[0|1]->Preheader != nullptr ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63844/new/

https://reviews.llvm.org/D63844