[PATCH] D63890: [CodeGen] First steps at porting CodeGen to new pass manager,

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 28 03:26:25 PDT 2019


fedor.sergeev added a comment.

Thanks for starting this effort!

I have not yet spent any good time reviewing this but it is rather obvious that the patch is too large.
It it needs to be broken into a series of patches, at least separating:

- introduction of Machine-level NewPM constructs, with its own unit tests etc
- porting legacy passes into newpm passes

Say, all those changes that just rename MachineModuleInfo into MachineModuleInfoWrapperPass are quite distracting.
But as I said, thanks for the effort!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63890/new/

https://reviews.llvm.org/D63890





More information about the llvm-commits mailing list