[PATCH] D63890: [CodeGen] First steps at porting CodeGen to new pass manager,

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUMachineFunction.cpp:32-39
+  // FIXME. How do we resolve this with the new PM?
+  // if (auto *Resolver = MF.getMMI().getResolver()) {
+  //   if (AMDGPUPerfHintAnalysis *PHA = static_cast<AMDGPUPerfHintAnalysis*>(
+  //         Resolver->getAnalysisIfAvailable(&AMDGPUPerfHintAnalysisID, true))) {
+  //     MemoryBound = PHA->isMemoryBound(&F);
+  //     WaveLimiter = PHA->needsWaveLimiter(&F);
+  //   }
----------------
This should really be a MachineFunction analysis. Would adding a separate MachineFunction pass with a dependency on this analysis which sets the field here work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63890/new/

https://reviews.llvm.org/D63890