[PATCH] D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked 2 inline comments as done.
mstorsjo added inline comments.


================
Comment at: COFF/Writer.cpp:656
 
+void Writer::fixPartialSectionChars(StringRef Name, uint32_t Chars) {
+  for (auto It : PartialSections) {
----------------
ruiu wrote:
> Can you add a function comment?
Sure, adding one that says "Change the characteristics of existing PartialSections that belong to the section Name to Chars."


================
Comment at: COFF/Writer.cpp:657
+void Writer::fixPartialSectionChars(StringRef Name, uint32_t Chars) {
+  for (auto It : PartialSections) {
+    PartialSection *PSec = It.second;
----------------
ruiu wrote:
> Use an actual type instead of `auto`.
The type here is `std::map<PartialSectionKey, PartialSection *>::iterator`, so I think this is one of the cases where `auto` is warranted.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63837/new/

https://reviews.llvm.org/D63837