[PATCH] D63837: [LLD] [COFF] Fix .rsrc sections with differing permissions

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:656
 
+void Writer::fixPartialSectionChars(StringRef Name, uint32_t Chars) {
+  for (auto It : PartialSections) {
----------------
Can you add a function comment?


================
Comment at: COFF/Writer.cpp:657
+void Writer::fixPartialSectionChars(StringRef Name, uint32_t Chars) {
+  for (auto It : PartialSections) {
+    PartialSection *PSec = It.second;
----------------
Use an actual type instead of `auto`.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63837/new/

https://reviews.llvm.org/D63837