[PATCH] D63633: [WebAssembly] Fix p2align in assembler.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked an inline comment as done.
aardappel added inline comments.


================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:353
                        InstName.startswith("store") ||
                        InstName.startswith("atomic");
     if (IsLoadStore) {
----------------
aheejin wrote:
> aardappel wrote:
> > aheejin wrote:
> > > Can atomic operations take `p2align`? Looks like alignments for atomic instructions are [[ https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md#spec-changes | predefined ]]. 
> > They are still stored in the encoding, and the tablegen def doesn't seem to make a difference between atomic and normal loads as to wether p2align can be changed, but yeah, the spec seems to indicate they are fixed. I can force atomics to use natural alignment for now.
> You're right, we don't distinguish it in Tablegen... maybe we should.
Well, I presume they're in the encoding because we want to be able to relax the fixed alignment later.. if these instructions alignment is meant to be always fixed, they shouldn't be in the encoding.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63633/new/

https://reviews.llvm.org/D63633