[PATCH] D63633: [WebAssembly] Fix p2align in assembler.

[Heejin Ahn via Phabricator via llvm-commits]

aheejin accepted this revision.
aheejin added a comment.
This revision is now accepted and ready to land.

LGTM, as long as @sbc100 is ok



================
Comment at: lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:353
                        InstName.startswith("store") ||
                        InstName.startswith("atomic");
     if (IsLoadStore) {
----------------
aardappel wrote:
> aheejin wrote:
> > Can atomic operations take `p2align`? Looks like alignments for atomic instructions are [[ https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md#spec-changes | predefined ]]. 
> They are still stored in the encoding, and the tablegen def doesn't seem to make a difference between atomic and normal loads as to wether p2align can be changed, but yeah, the spec seems to indicate they are fixed. I can force atomics to use natural alignment for now.
You're right, we don't distinguish it in Tablegen... maybe we should.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63633/new/

https://reviews.llvm.org/D63633