[PATCH] D60601: [DAGCombiner] Exploiting more about the transformation of TransformFPLoadStorePair function

[Zixuan Wu via Phabricator via llvm-commits]

wuzish marked an inline comment as done.
wuzish added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/ldst-f32-2-i32.ll:57
+
+; CHECK-LABEL: _test:
+; CHECK: ldr r3, [pc, r3]
----------------
lebedev.ri wrote:
> steven.zhang wrote:
> > wuzish wrote:
> > > xbolva00 wrote:
> > > > Can you please remove test checks and regenerate them using update_llc_tests_checks.py script before you commit this patch ?
> > > > Thanks.
> > > I am afraid that -mtriple of darwin is not supported in update_llc_tests_checks.py after I try, and we just write checks manually.
> > Maybe, you can fix it as this patch did for darwin triple. https://reviews.llvm.org/D63723
> What @steven.zhang said, let's just add the support there :)
> I'd suggest to first try `'armv7-apple-darwin' : (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),`
> how does that look?
I have test all ASM_FUNCTION about AARCH64 and ARM, all of them don't work. I am afraid it's not among them. Need write a new regular expression.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60601/new/

https://reviews.llvm.org/D60601