[PATCH] D60601: [DAGCombiner] Exploiting more about the transformation of TransformFPLoadStorePair function

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 27 01:38:05 PDT 2019


lebedev.ri added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/ldst-f32-2-i32.ll:57
+
+; CHECK-LABEL: _test:
+; CHECK: ldr r3, [pc, r3]
----------------
steven.zhang wrote:
> wuzish wrote:
> > xbolva00 wrote:
> > > Can you please remove test checks and regenerate them using update_llc_tests_checks.py script before you commit this patch ?
> > > Thanks.
> > I am afraid that -mtriple of darwin is not supported in update_llc_tests_checks.py after I try, and we just write checks manually.
> Maybe, you can fix it as this patch did for darwin triple. https://reviews.llvm.org/D63723
What @steven.zhang said, let's just add the support there :)
I'd suggest to first try `'armv7-apple-darwin' : (scrub_asm_arm_eabi, ASM_FUNCTION_AARCH64_DARWIN_RE),`
how does that look?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60601/new/

https://reviews.llvm.org/D60601





More information about the llvm-commits mailing list