[PATCH] D61694: Boilerplate for producing XCOFF object files from the PowerPC backend.

[Sean Fertile via Phabricator via llvm-commits]

sfertile updated this revision to Diff 206710.
sfertile marked an inline comment as not done.
sfertile added a comment.
Herald added a subscriber: aheejin.

Addressed review comments:

- Fixed up several comments
- removed overridden functions that only called based class implementation.
- fixed up logic for creating an MCAsmInfo and Streamers so that Linux/ELF remains the default.
- Removed code for registering an XCOFFStreamer creation callback as no classes extend the XCOFF streamer.
- reviewed usage of assert/llvm_unreachable. Converted most to report_fatal_error
- Always use a timestamp of '0' for reproducible. Fatal error if incremental linking is enabled.

Added MCSectionXCOFF class so we can create and switch to the .text section. This was implemented by Jason Liu, and it was in the branch I did the boilerplate work on, but wasn't up streamed itself as it was not testable on its own.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61694/new/

https://reviews.llvm.org/D61694

Files:
  llvm/include/llvm/BinaryFormat/XCOFF.h
  llvm/include/llvm/MC/MCAsmInfoXCOFF.h
  llvm/include/llvm/MC/MCContext.h
  llvm/include/llvm/MC/MCObjectFileInfo.h
  llvm/include/llvm/MC/MCSection.h
  llvm/include/llvm/MC/MCSectionXCOFF.h
  llvm/include/llvm/MC/MCXCOFFObjectWriter.h
  llvm/include/llvm/MC/MCXCOFFStreamer.h
  llvm/include/llvm/Support/TargetRegistry.h
  llvm/lib/MC/CMakeLists.txt
  llvm/lib/MC/MCAsmBackend.cpp
  llvm/lib/MC/MCAsmInfoXCOFF.cpp
  llvm/lib/MC/MCContext.cpp
  llvm/lib/MC/MCObjectFileInfo.cpp
  llvm/lib/MC/MCSectionXCOFF.cpp
  llvm/lib/MC/MCXCOFFObjectTargetWriter.cpp
  llvm/lib/MC/MCXCOFFStreamer.cpp
  llvm/lib/MC/XCOFFObjectWriter.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/CMakeLists.txt
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCAsmInfo.h
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.cpp
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCMCTargetDesc.h
  llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFObjectWriter.cpp
  llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp
  llvm/test/CodeGen/PowerPC/aix-xcoff-basic.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61694.206710.patch
Type: text/x-patch
Size: 35323 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190626/747477c7/attachment.bin>