[llvm] r364455 - Revert [InstCombine] change 'tmp' variable names; NFC
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 26 11:09:51 PDT 2019
I was trying to avoid a bug and caused one instead with this commit by
including some unintended test changes. And then further botched it by not
amending the revert message with this explanation.
On Wed, Jun 26, 2019 at 12:06 PM Sanjay Patel via llvm-commits <
llvm-commits at lists.llvm.org> wrote:
> Author: spatel
> Date: Wed Jun 26 11:06:51 2019
> New Revision: 364455
>
> URL: http://llvm.org/viewvc/llvm-project?rev=364455&view=rev
> Log:
> Revert [InstCombine] change 'tmp' variable names; NFC
>
> This reverts r364452 (git commit 6083ae0b4a250c69f6d5b13b3742ee1fe5b878d5)
>
> Modified:
> llvm/trunk/test/Transforms/InstCombine/broadcast.ll
>
> Modified: llvm/trunk/test/Transforms/InstCombine/broadcast.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/broadcast.ll?rev=364455&r1=364454&r2=364455&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/Transforms/InstCombine/broadcast.ll (original)
> +++ llvm/trunk/test/Transforms/InstCombine/broadcast.ll Wed Jun 26
> 11:06:51 2019
> @@ -3,56 +3,56 @@
>
> define <4 x float> @good1(float %arg) {
> ; CHECK-LABEL: @good1(
> -; CHECK-NEXT: [[T:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[T6:%.*]] = shufflevector <4 x float> [[T]], <4 x
> float> undef, <4 x i32> zeroinitializer
> -; CHECK-NEXT: ret <4 x float> [[T6]]
> -;
> - %t = insertelement <4 x float> undef, float %arg, i32 0
> - %t4 = insertelement <4 x float> %t, float %arg, i32 1
> - %t5 = insertelement <4 x float> %t4, float %arg, i32 2
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - ret <4 x float> %t6
> +; CHECK-NEXT: [[TMP:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> +; CHECK-NEXT: [[TMP6:%.*]] = shufflevector <4 x float> [[TMP]], <4 x
> float> undef, <4 x i32> zeroinitializer
> +; CHECK-NEXT: ret <4 x float> [[TMP6]]
> +;
> + %tmp = insertelement <4 x float> undef, float %arg, i32 0
> + %tmp4 = insertelement <4 x float> %tmp, float %arg, i32 1
> + %tmp5 = insertelement <4 x float> %tmp4, float %arg, i32 2
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + ret <4 x float> %tmp6
> }
>
> define <4 x float> @good2(float %arg) {
> ; CHECK-LABEL: @good2(
> ; CHECK-NEXT: [[TMP1:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[T6:%.*]] = shufflevector <4 x float> [[TMP1]], <4 x
> float> undef, <4 x i32> zeroinitializer
> -; CHECK-NEXT: ret <4 x float> [[T6]]
> +; CHECK-NEXT: [[TMP6:%.*]] = shufflevector <4 x float> [[TMP1]], <4 x
> float> undef, <4 x i32> zeroinitializer
> +; CHECK-NEXT: ret <4 x float> [[TMP6]]
> ;
> - %t = insertelement <4 x float> undef, float %arg, i32 1
> - %t4 = insertelement <4 x float> %t, float %arg, i32 2
> - %t5 = insertelement <4 x float> %t4, float %arg, i32 0
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - ret <4 x float> %t6
> + %tmp = insertelement <4 x float> undef, float %arg, i32 1
> + %tmp4 = insertelement <4 x float> %tmp, float %arg, i32 2
> + %tmp5 = insertelement <4 x float> %tmp4, float %arg, i32 0
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + ret <4 x float> %tmp6
> }
>
> define <4 x float> @good3(float %arg) {
> ; CHECK-LABEL: @good3(
> -; CHECK-NEXT: [[T:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[T6:%.*]] = shufflevector <4 x float> [[T]], <4 x
> float> undef, <4 x i32> zeroinitializer
> -; CHECK-NEXT: ret <4 x float> [[T6]]
> -;
> - %t = insertelement <4 x float> zeroinitializer, float %arg, i32 0
> - %t4 = insertelement <4 x float> %t, float %arg, i32 1
> - %t5 = insertelement <4 x float> %t4, float %arg, i32 2
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - ret <4 x float> %t6
> +; CHECK-NEXT: [[TMP:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> +; CHECK-NEXT: [[TMP6:%.*]] = shufflevector <4 x float> [[TMP]], <4 x
> float> undef, <4 x i32> zeroinitializer
> +; CHECK-NEXT: ret <4 x float> [[TMP6]]
> +;
> + %tmp = insertelement <4 x float> zeroinitializer, float %arg, i32 0
> + %tmp4 = insertelement <4 x float> %tmp, float %arg, i32 1
> + %tmp5 = insertelement <4 x float> %tmp4, float %arg, i32 2
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + ret <4 x float> %tmp6
> }
>
> define <4 x float> @good4(float %arg) {
> ; CHECK-LABEL: @good4(
> -; CHECK-NEXT: [[T:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[TMP1:%.*]] = fadd <4 x float> [[T]], [[T]]
> -; CHECK-NEXT: [[T7:%.*]] = shufflevector <4 x float> [[TMP1]], <4 x
> float> undef, <4 x i32> zeroinitializer
> -; CHECK-NEXT: ret <4 x float> [[T7]]
> -;
> - %t = insertelement <4 x float> zeroinitializer, float %arg, i32 0
> - %t4 = insertelement <4 x float> %t, float %arg, i32 1
> - %t5 = insertelement <4 x float> %t4, float %arg, i32 2
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - %t7 = fadd <4 x float> %t6, %t6
> - ret <4 x float> %t7
> +; CHECK-NEXT: [[TMP:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> +; CHECK-NEXT: [[TMP1:%.*]] = fadd <4 x float> [[TMP]], [[TMP]]
> +; CHECK-NEXT: [[TMP7:%.*]] = shufflevector <4 x float> [[TMP1]], <4 x
> float> undef, <4 x i32> zeroinitializer
> +; CHECK-NEXT: ret <4 x float> [[TMP7]]
> +;
> + %tmp = insertelement <4 x float> zeroinitializer, float %arg, i32 0
> + %tmp4 = insertelement <4 x float> %tmp, float %arg, i32 1
> + %tmp5 = insertelement <4 x float> %tmp4, float %arg, i32 2
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + %tmp7 = fadd <4 x float> %tmp6, %tmp6
> + ret <4 x float> %tmp7
> }
>
> define <4 x float> @good5(float %v) {
> @@ -74,83 +74,85 @@ define <4 x float> @good5(float %v) {
>
> define <4 x float> @bad1(float %arg) {
> ; CHECK-LABEL: @bad1(
> -; CHECK-NEXT: [[TMP1:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[T6:%.*]] = shufflevector <4 x float> [[TMP1]], <4 x
> float> undef, <4 x i32> <i32 undef, i32 0, i32 0, i32 0>
> -; CHECK-NEXT: ret <4 x float> [[T6]]
> -;
> - %t = insertelement <4 x float> undef, float %arg, i32 1
> - %t4 = insertelement <4 x float> %t, float %arg, i32 1
> - %t5 = insertelement <4 x float> %t4, float %arg, i32 2
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - ret <4 x float> %t6
> +; CHECK-NEXT: [[TMP4:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 1
> +; CHECK-NEXT: [[TMP5:%.*]] = insertelement <4 x float> [[TMP4]], float
> [[ARG]], i32 2
> +; CHECK-NEXT: [[TMP6:%.*]] = insertelement <4 x float> [[TMP5]], float
> [[ARG]], i32 3
> +; CHECK-NEXT: ret <4 x float> [[TMP6]]
> +;
> + %tmp = insertelement <4 x float> undef, float %arg, i32 1
> + %tmp4 = insertelement <4 x float> %tmp, float %arg, i32 1
> + %tmp5 = insertelement <4 x float> %tmp4, float %arg, i32 2
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + ret <4 x float> %tmp6
> }
>
> define <4 x float> @bad2(float %arg) {
> ; CHECK-LABEL: @bad2(
> -; CHECK-NEXT: [[T:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[T6:%.*]] = shufflevector <4 x float> [[T]], <4 x
> float> undef, <4 x i32> <i32 0, i32 undef, i32 0, i32 0>
> -; CHECK-NEXT: ret <4 x float> [[T6]]
> -;
> - %t = insertelement <4 x float> undef, float %arg, i32 0
> - %t5 = insertelement <4 x float> %t, float %arg, i32 2
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - ret <4 x float> %t6
> +; CHECK-NEXT: [[TMP:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> +; CHECK-NEXT: [[TMP5:%.*]] = insertelement <4 x float> [[TMP]], float
> [[ARG]], i32 2
> +; CHECK-NEXT: [[TMP6:%.*]] = insertelement <4 x float> [[TMP5]], float
> [[ARG]], i32 3
> +; CHECK-NEXT: ret <4 x float> [[TMP6]]
> +;
> + %tmp = insertelement <4 x float> undef, float %arg, i32 0
> + %tmp5 = insertelement <4 x float> %tmp, float %arg, i32 2
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + ret <4 x float> %tmp6
> }
>
> define <4 x float> @bad3(float %arg, float %arg2) {
> ; CHECK-LABEL: @bad3(
> -; CHECK-NEXT: [[T:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[T4:%.*]] = insertelement <4 x float> [[T]], float
> [[ARG2:%.*]], i32 1
> -; CHECK-NEXT: [[T5:%.*]] = insertelement <4 x float> [[T4]], float
> [[ARG]], i32 2
> -; CHECK-NEXT: [[T6:%.*]] = insertelement <4 x float> [[T5]], float
> [[ARG]], i32 3
> -; CHECK-NEXT: ret <4 x float> [[T6]]
> -;
> - %t = insertelement <4 x float> undef, float %arg, i32 0
> - %t4 = insertelement <4 x float> %t, float %arg2, i32 1
> - %t5 = insertelement <4 x float> %t4, float %arg, i32 2
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - ret <4 x float> %t6
> +; CHECK-NEXT: [[TMP:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> +; CHECK-NEXT: [[TMP4:%.*]] = insertelement <4 x float> [[TMP]], float
> [[ARG2:%.*]], i32 1
> +; CHECK-NEXT: [[TMP5:%.*]] = insertelement <4 x float> [[TMP4]], float
> [[ARG]], i32 2
> +; CHECK-NEXT: [[TMP6:%.*]] = insertelement <4 x float> [[TMP5]], float
> [[ARG]], i32 3
> +; CHECK-NEXT: ret <4 x float> [[TMP6]]
> +;
> + %tmp = insertelement <4 x float> undef, float %arg, i32 0
> + %tmp4 = insertelement <4 x float> %tmp, float %arg2, i32 1
> + %tmp5 = insertelement <4 x float> %tmp4, float %arg, i32 2
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + ret <4 x float> %tmp6
> }
>
> define <1 x float> @bad4(float %arg) {
> ; CHECK-LABEL: @bad4(
> -; CHECK-NEXT: [[T:%.*]] = insertelement <1 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: ret <1 x float> [[T]]
> +; CHECK-NEXT: [[TMP:%.*]] = insertelement <1 x float> undef, float
> [[ARG:%.*]], i32 0
> +; CHECK-NEXT: ret <1 x float> [[TMP]]
> ;
> - %t = insertelement <1 x float> undef, float %arg, i32 0
> - ret <1 x float> %t
> + %tmp = insertelement <1 x float> undef, float %arg, i32 0
> + ret <1 x float> %tmp
> }
>
> define <4 x float> @bad5(float %arg) {
> ; CHECK-LABEL: @bad5(
> -; CHECK-NEXT: [[T:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[T4:%.*]] = shufflevector <4 x float> [[T]], <4 x
> float> undef, <4 x i32> <i32 0, i32 0, i32 undef, i32 undef>
> -; CHECK-NEXT: [[T5:%.*]] = insertelement <4 x float> [[T4]], float
> [[ARG]], i32 2
> -; CHECK-NEXT: [[T6:%.*]] = insertelement <4 x float> [[T5]], float
> [[ARG]], i32 3
> -; CHECK-NEXT: [[T7:%.*]] = fadd <4 x float> [[T6]], [[T4]]
> -; CHECK-NEXT: ret <4 x float> [[T7]]
> -;
> - %t = insertelement <4 x float> undef, float %arg, i32 0
> - %t4 = insertelement <4 x float> %t, float %arg, i32 1
> - %t5 = insertelement <4 x float> %t4, float %arg, i32 2
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - %t7 = fadd <4 x float> %t6, %t4
> - ret <4 x float> %t7
> +; CHECK-NEXT: [[TMP:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> +; CHECK-NEXT: [[TMP4:%.*]] = insertelement <4 x float> [[TMP]], float
> [[ARG]], i32 1
> +; CHECK-NEXT: [[TMP5:%.*]] = insertelement <4 x float> [[TMP4]], float
> [[ARG]], i32 2
> +; CHECK-NEXT: [[TMP6:%.*]] = insertelement <4 x float> [[TMP5]], float
> [[ARG]], i32 3
> +; CHECK-NEXT: [[TMP7:%.*]] = fadd <4 x float> [[TMP6]], [[TMP4]]
> +; CHECK-NEXT: ret <4 x float> [[TMP7]]
> +;
> + %tmp = insertelement <4 x float> undef, float %arg, i32 0
> + %tmp4 = insertelement <4 x float> %tmp, float %arg, i32 1
> + %tmp5 = insertelement <4 x float> %tmp4, float %arg, i32 2
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + %tmp7 = fadd <4 x float> %tmp6, %tmp4
> + ret <4 x float> %tmp7
> }
>
> define <4 x float> @bad6(float %arg, i32 %k) {
> ; CHECK-LABEL: @bad6(
> -; CHECK-NEXT: [[T:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> -; CHECK-NEXT: [[T4:%.*]] = insertelement <4 x float> [[T]], float
> [[ARG]], i32 1
> -; CHECK-NEXT: [[T5:%.*]] = insertelement <4 x float> [[T4]], float
> [[ARG]], i32 [[K:%.*]]
> -; CHECK-NEXT: [[T6:%.*]] = insertelement <4 x float> [[T5]], float
> [[ARG]], i32 3
> -; CHECK-NEXT: ret <4 x float> [[T6]]
> -;
> - %t = insertelement <4 x float> undef, float %arg, i32 0
> - %t4 = insertelement <4 x float> %t, float %arg, i32 1
> - %t5 = insertelement <4 x float> %t4, float %arg, i32 %k
> - %t6 = insertelement <4 x float> %t5, float %arg, i32 3
> - ret <4 x float> %t6
> +; CHECK-NEXT: [[TMP:%.*]] = insertelement <4 x float> undef, float
> [[ARG:%.*]], i32 0
> +; CHECK-NEXT: [[TMP4:%.*]] = insertelement <4 x float> [[TMP]], float
> [[ARG]], i32 1
> +; CHECK-NEXT: [[TMP5:%.*]] = insertelement <4 x float> [[TMP4]], float
> [[ARG]], i32 [[K:%.*]]
> +; CHECK-NEXT: [[TMP6:%.*]] = insertelement <4 x float> [[TMP5]], float
> [[ARG]], i32 3
> +; CHECK-NEXT: ret <4 x float> [[TMP6]]
> +;
> + %tmp = insertelement <4 x float> undef, float %arg, i32 0
> + %tmp4 = insertelement <4 x float> %tmp, float %arg, i32 1
> + %tmp5 = insertelement <4 x float> %tmp4, float %arg, i32 %k
> + %tmp6 = insertelement <4 x float> %tmp5, float %arg, i32 3
> + ret <4 x float> %tmp6
> }
>
> define <4 x float> @bad7(float %v) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190626/4dee8d91/attachment.html>
More information about the llvm-commits
mailing list