[PATCH] D63779: [llvm-objdump] Warn if no user specified sections (-j) are not found.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:451
+  // iteration to match GNU output order.
+  for (auto S : make_range(MissingSections.rbegin(), MissingSections.rend()))
+    warn("section '" + S + "' mentioned in a -j/--section option, but not "
----------------
MaskRay wrote:
> I remember @jhenderson said the warning order did not matter.
> 
> Then, why don't we use the simpler `for (StringRef S : MissingSections)`?
Yes, exactly. I don't see a particular reason to follow GNU on warning ordering or even text, as long as what we say makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63779/new/

https://reviews.llvm.org/D63779