[PATCH] D63779: [llvm-objdump] Warn if no user specified sections (-j) are not found.
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 25 19:50:48 PDT 2019
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:451
+ // iteration to match GNU output order.
+ for (auto S : make_range(MissingSections.rbegin(), MissingSections.rend()))
+ warn("section '" + S + "' mentioned in a -j/--section option, but not "
----------------
I remember @jhenderson said the warning order did not matter.
Then, why don't we use the simpler `for (StringRef S : MissingSections)`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63779/new/
https://reviews.llvm.org/D63779
More information about the llvm-commits
mailing list