[PATCH] D63722: [docs][llvm-cxxfilt] Write llvm-cxxfilt documentation

Tue Jun 25 03:25:32 PDT 2019

jhenderson marked an inline comment as done.
jhenderson added inline comments.

================
Comment at: docs/CommandGuide/llvm-cxxfilt.rst:43
+  Mangling scheme to assume. Valid values are ``auto`` (default, auto-detect the
+  style) and ``gnu`` (assume GNU/Itanium style).
+
----------------
mattd wrote:
> Perhaps I'm being overly pedantic, but Itanium section 5.1.1 mentions that: "Mangled names containing '$' or '.' are reserved for private implementation use" [http://itanium-cxx-abi.github.io/cxx-abi/abi.html].   I do not know if GNU chooses to represent those characters differently; I recall a difference, but it might be more confusing to spell that out in this option description.
I don't think it's worth going into that level of pedantry, mainly because only one style is actually supported. I also don't think it's within the scope of the llvm-cxxfilt documentation to explain how names are demangled. (I note for example that `._Z3foov` demangles to `.foo()` for GNU c++filt, but does not demangle for llvm-cxxfilt.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63722/new/

https://reviews.llvm.org/D63722