[PATCH] D63722: [docs][llvm-cxxfilt] Write llvm-cxxfilt documentation

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 10:28:49 PDT 2019


mattd accepted this revision.
mattd added a comment.
This revision is now accepted and ready to land.

This looks great! Thanks.



================
Comment at: docs/CommandGuide/llvm-cxxfilt.rst:43
+  Mangling scheme to assume. Valid values are ``auto`` (default, auto-detect the
+  style) and ``gnu`` (assume GNU/Itanium style).
+
----------------
Perhaps I'm being overly pedantic, but Itanium section 5.1.1 mentions that: "Mangled names containing '$' or '.' are reserved for private implementation use" [http://itanium-cxx-abi.github.io/cxx-abi/abi.html].   I do not know if GNU chooses to represent those characters differently; I recall a difference, but it might be more confusing to spell that out in this option description.


================
Comment at: docs/CommandGuide/llvm-cxxfilt.rst:70
+
+EXIT CODE
+---------
----------------
nit:  "EXIT STATUS" seems to be the more common section name.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63722/new/

https://reviews.llvm.org/D63722





More information about the llvm-commits mailing list