[PATCH] D63743: [llvm-shlib] Do not use version script when building with MinGW and LLD

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 22:21:02 PDT 2019


mstorsjo added a reviewer: rnk.
mstorsjo added a comment.

I'd suggest skipping the lld condition, the version script adds no value here.

For ELF, version scripts do two things, select what symbols to export using glob pattetns, and set symbol versions on them.

As COFF doesn't have symbol versions, all it does on mingw with GNU ld, is filtering symbols, to export *. So it adds no value there.

(I don't remember if cmake even knows the linker is lld in my mingw setups.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63743/new/

https://reviews.llvm.org/D63743





More information about the llvm-commits mailing list