[PATCH] D63743: [llvm-shlib] Do not use version script when building with MinGW and LLD

[Pirama Arumuga Nainar via Phabricator via llvm-commits]

pirama created this revision.
pirama added reviewers: srhines, mstorsjo.
Herald added subscribers: fedor.sergeev, mgorny.
Herald added a project: LLVM.

The MinGW driver for lld does not support the -version-script option.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63743

Files:
  llvm/tools/llvm-shlib/CMakeLists.txt


Index: llvm/tools/llvm-shlib/CMakeLists.txt
===================================================================
--- llvm/tools/llvm-shlib/CMakeLists.txt
+++ llvm/tools/llvm-shlib/CMakeLists.txt
@@ -55,7 +55,8 @@
 
     # GNU ld doesn't resolve symbols in the version script.
     set(LIB_NAMES -Wl,--whole-archive ${LIB_NAMES} -Wl,--no-whole-archive)
-    if (NOT LLVM_LINKER_IS_SOLARISLD)
+    if (NOT LLVM_LINKER_IS_SOLARISLD
+        AND NOT (MINGW AND LINKER_IS_LLD_LINK))
       # Solaris ld does not accept global: *; so there is no way to version *all* global symbols
       set(LIB_NAMES -Wl,--version-script,${LLVM_LIBRARY_DIR}/tools/llvm-shlib/simple_version_script.map ${LIB_NAMES})
     endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63743.206316.patch
Type: text/x-patch
Size: 707 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190624/e81d448a/attachment.bin>