[PATCH] D63736: [GWP-ASan] Guard against recursive allocs. Pack TLS for perf.

Mon Jun 24 15:30:26 PDT 2019

vlad.tsyrklevich added a comment.

In D63736#1556463 <https://reviews.llvm.org/D63736#1556463>, @hctim wrote:

> In D63736#1556349 <https://reviews.llvm.org/D63736#1556349>, @eugenis wrote:
>
> > Do we need similar protection in deallocate?
>
>
> We shouldn't need to. `GPA::deallocate()` may call `malloc()` and `free()`, but can only be called with guarded allocations. Recursion is okay (and desirable, as the unwinder's implementation is okay to be sampled) in `deallocate()`.

Don't we hold the Mutex during AllocationMetadata::RecordDeallocation()? Doesn't that mean that the unwinder could cause deadlock during deallocation?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63736/new/

https://reviews.llvm.org/D63736