[PATCH] D63736: [GWP-ASan] Guard against recursive allocs. Pack TLS for perf.

Mitch Phillips via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 24 14:56:56 PDT 2019


hctim added a comment.

In D63736#1556349 <https://reviews.llvm.org/D63736#1556349>, @eugenis wrote:

> Do we need similar protection in deallocate?


We shouldn't need to. `GPA::deallocate()` may call `malloc()` and `free()`, but can only be called with guarded allocations. Recursion is okay (and desirable, as the unwinder's implementation is okay to be sampled) in `deallocate()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63736/new/

https://reviews.llvm.org/D63736





More information about the llvm-commits mailing list