[PATCH] D63711: [ARM] MVE VPT Blocks

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp:405
+    finalizeBundle(Block, VPSTInsertPos.getInstrIterator(),
                    ++LastMI->getIterator());
+
----------------
samparker wrote:
> But we don't need LastMI at all :)
I think I see what you mean, you want to see:

  finalizeBundle(Block, VPSTInsertPos.getInstrIterator(), MBIter);

But they are different iterators: 
- MBIter is a MachineBasicBlock::iterator
- and finalizeBundle expects a MachineBasicBlock::instr_iterator

I didn't really investigate the difference to be honest, but must be related to iterating over instructions of blocks or bundles.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63711/new/

https://reviews.llvm.org/D63711