[PATCH] D63711: [ARM] MVE VPT Blocks

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb2ITBlockPass.cpp:405
+    finalizeBundle(Block, VPSTInsertPos.getInstrIterator(),
                    ++LastMI->getIterator());
+
----------------
But we don't need LastMI at all :)


================
Comment at: llvm/test/CodeGen/ARM/mve-vpt-block5.mir:66
+
+    ; CHECK:       BUNDLE {{.*}} {
+    ; CHECK-NEXT:    MVE_VPST 8, implicit-def $p0
----------------
SjoerdMeijer wrote:
> samparker wrote:
> > So why do we have two bundles here? I'm missing something...
> because there is a MOV in between the 2nd and 3rd MVE_VMINNMf32 instructions:
> 
>   $q3 = MVE_VORR $q0, $q0, 0, $noreg, undef $q3
cheers!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63711/new/

https://reviews.llvm.org/D63711