[PATCH] D63470: hwasan: Remove the old frame descriptor mechanism.

Fri Jun 21 16:48:05 PDT 2019

eugenis added inline comments.

================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:154
-                              cl::desc("create static frame descriptions"),
-                              cl::Hidden, cl::init(true));
-
----------------
pcc wrote:
> eugenis wrote:
> > We use this in android (hwasan-create-frame-descriptions=0). Could we keep the flag around for a while?
> Yeah, I needed to hack the flag back in (similar to https://github.com/pcc/llvm-project/commit/576c50647de5bda105cf79e97d30d0f452d7986f) to get the Android build working again. Since there's no guarantee of stability around these flags, maybe Android should be doing something similar in their compiler temporarily?
That could be a better option.
In hindsight, we should not have enabled this experimental feature by default.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63470/new/

https://reviews.llvm.org/D63470