[PATCH] D63470: hwasan: Remove the old frame descriptor mechanism.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 21 16:41:14 PDT 2019
pcc marked an inline comment as done.
pcc added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:154
- cl::desc("create static frame descriptions"),
- cl::Hidden, cl::init(true));
-
----------------
eugenis wrote:
> We use this in android (hwasan-create-frame-descriptions=0). Could we keep the flag around for a while?
Yeah, I needed to hack the flag back in (similar to https://github.com/pcc/llvm-project/commit/576c50647de5bda105cf79e97d30d0f452d7986f) to get the Android build working again. Since there's no guarantee of stability around these flags, maybe Android should be doing something similar in their compiler temporarily?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63470/new/
https://reviews.llvm.org/D63470
More information about the llvm-commits
mailing list